Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PowerShell completion setup documentation #3131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

l0calh05t
Copy link

Fixes #3128

@rbtcollins
Copy link
Contributor

Sorry for not reviewing this early. You have a lint failure of some sort - either formatting or clippy - if you could fix this we can merge it I think. Thanks!

@l0calh05t
Copy link
Author

l0calh05t commented May 29, 2023

Sorry for not reviewing this early. You have a lint failure of some sort - either formatting or clippy - if you could fix this we can merge it I think. Thanks!

If I remember correctly, the error was unrelated to my commit. However, due to the age, the logs had been deleted. I merged the current master to trigger a rerun, now the general checks succeed, but the Linux build failed - again with an error unrelated to my commit:

Run arduino/setup-protoc@v1
Error: API rate limit exceeded for 104.45.202.145. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

@rbtcollins
Copy link
Contributor

rbtcollins commented May 30, 2023

@l0calh05t our UI tests are failing though. These are new since your PR I think.


---- suite::cli_ui::rustup_ui_doc_text_tests stdout ----
thread 'suite::cli_ui::rustup_ui_doc_text_tests' panicked at '1 of 44 tests failed', /cargo/registry/src/github.com-1ecc6299db9ec823/trycmd-0.14.16/src/runner.rs:104:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    suite::cli_ui::rustup_ui_doc_text_tests

@Rustin170506
Copy link
Member

@l0calh05t Friendly ping~

Do you have time to update the tests then we can move forward with this PR? Thanks!

@l0calh05t
Copy link
Author

I'll try to get around to it this weekend/early next week

@rami3l
Copy link
Member

rami3l commented May 25, 2024

@l0calh05t Hi there, and thanks a lot for your contribution!

Our team members have changed and now I'm here trying to pick up the lost context. Currently it looks like that #3128 has been closed by @djc's #3444, so I'm wondering if you still have remaining concerns regarding #3128, or we can safely close this PR?

Many thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PowerShell completions installation does not work as documented
4 participants